Skip to content

Fix count php 7.2 #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix count php 7.2 #602

wants to merge 5 commits into from

Conversation

dyorg
Copy link

@dyorg dyorg commented Feb 20, 2019 •
edited
Loading

  • Fixed count() error in php 7.2
  • Added php 7.2 on trevis tests
  • Fix count() errors on phpunit tests
  • Change travis test php 5.3 to Precise, because now is necessary explicitly stay on Precise. See warning note in the last travis builder of PHP 5.3.

@dyorg
Copy link
Author

dyorg commented Feb 20, 2019

@jpfuentes2 Please see this PR. Thanks!

willy68 added a commit to willy68/php-activerecord-dev that referenced this pull request Mar 10, 2020
@willy68
Fix count php 7.2 jpfuentes2#602
a1fdd82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@SHEFF003 SHEFF003 SHEFF003 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyorg @SHEFF003